Re: Issue with multiple inputs mapped to single output while recording.

On Sun, Sep 06, 2020 at 08:24:56PM +0000, bang corrupt wrote:
> Hi,
> 
> Midish is awesome, thank you.  
> 
> I'm experiencing an issue when recording with multiple inputs mapped to a
> single output.
> 
> If the same note is sent from two inputs simultaneously, the program aborts and
> the core is dumped.  This only occurs while recording.  In playback mode the
> notes are killed without issue.  
> 
> The log displays:
> "non {1 2} 38 4f NEW CHANGED NESTED FIRST: norm filter failed" 
> and the call to panic() at line 1222 of song.c is triggered.
> 
> To reproduce the issue, map notes from 2 keyboards to one synth, start
> recording and play the same note simultaneously from both keyboards.
> 
> I have only tested this on my PC and a raspberry pi 2 B+, both running
> ArchLinux.  
> 
> Does Midish support mapping multiple inputs to a single output?
> 

Hi,

Yes it supports this case.  BTW, there are many other situations
resulting in nested notes and they are supposed to be properly
filtered when necessary.

> Is there a workaround?  
> 
> I don't know enough to debug further, but maybe setting priorities for inputs,
> or making 2 devices appear to be a single input could help.  
> 
> Any help is greatly appreciated,  I'm happy to provide more information if I
> know what's needed.

There was a wrong assertion in the code, that is fixed now. Thanks for
reporting the bug.